Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(node): drop node v4 and v5 (#917) #157

Merged
merged 1 commit into from Dec 2, 2018
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
2 changes: 0 additions & 2 deletions .travis.yml
@@ -1,8 +1,6 @@
language: node_js
sudo: false
node_js:
- 4
- 5
- 6
- 7
- 8
Expand Down
2 changes: 1 addition & 1 deletion README.md
Expand Up @@ -10,7 +10,7 @@
commands, providing an easy solution for simple Unix-like, cross-platform
commands in npm package scripts.

`shx` is proudly tested on every node release since <!-- start minVersion -->`v4`<!-- stop minVersion -->!
`shx` is proudly tested on every node release since <!-- start minVersion -->`v6`<!-- stop minVersion -->!

## Difference Between ShellJS and shx

Expand Down
2 changes: 0 additions & 2 deletions appveyor.yml
Expand Up @@ -5,8 +5,6 @@ environment:
- nodejs_version: '8'
- nodejs_version: '7'
- nodejs_version: '6'
- nodejs_version: '5'
- nodejs_version: '4'

version: '{build}'

Expand Down
2 changes: 1 addition & 1 deletion package.json
Expand Up @@ -75,6 +75,6 @@
"shelljs": "^0.8.1"
},
"engines": {
"node": ">=4"
"node": ">=6"
}
}
4 changes: 2 additions & 2 deletions scripts/check-node-support.js
Expand Up @@ -8,7 +8,7 @@ var yaml = require('js-yaml');
var shell = require('shelljs');

// This is the authoritative list of supported node versions.
var MIN_NODE_VERSION = 4;
var MIN_NODE_VERSION = 6;
var MAX_NODE_VERSION = 10;

function checkReadme(minNodeVersion) {
Expand All @@ -19,7 +19,7 @@ function checkReadme(minNodeVersion) {
start + '\\s*' + formattedMinVersion + '\\s*' + stop, '');
var readme = path.join(__dirname, '..', 'README.md');
var match = shell.grep(expectedReadmeRegex, readme);
if (!match.toString()) {
if (!match.toString().trim()) {
var msg = 'Update README to specify the min supported version. Look for "'
+ start + '"';
throw new Error(msg);
Expand Down