chore(node): drop node v4 and v5 (#917) #157
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This drops support for node v4 and v5. Neither is currently supported by the Node.js team, nor by the `npm` CLI team, so it's hard to justify we continue to support it. The new minimum supported version is v6. This also fixes a bug in the check-node-support script. Issue shelljs/shelljs#873
Codecov Report
@@ Coverage Diff @@
## master #157 +/- ##
=====================================
Coverage 100% 100%
=====================================
Files 5 5
Lines 88 88
=====================================
Hits 88 88Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This drops support for node v4 and v5. Neither is currently supported by
the Node.js team, nor by the
npmCLI team, so it's hard to justify wecontinue to support it.
The new minimum supported version is v6.
This also fixes a bug in the check-node-support script (see
shelljs/shelljs#901).
Issue shelljs/shelljs#873