Lambci #15
Lambci #15
Conversation
There was a problem hiding this comment.
This change represents a great deal of progress by adding support for custom runtimes and layers on Lambda, as well as for the Docker-based Lambda-like environment that can run either locally or on a remote server. I can suggest a number of enhancements that should probably be deferred to a separate task in the interest of getting this merged: 1/ provide SRK mechanism to start the lambci provider, 2/ review use of SSH and consider using Go rather than system libraries, 3/ some reorganization of the documentation.
There was a problem hiding this comment.
lots of inline comments.
Some broad comments:
- More comments would be nice, at least at the tops of functions (e.g. 'NextLayerVersion' in lambci-lambda/util.go)
- More docs, lots of this stuff was new to me and even after reading the code I wasn't 100% sure what it did.
- I'm still pretty unclear on runtimes, layers, and how tied they are to providers.
In principle, this all looks good.
There was a problem hiding this comment.
@NathanTP, thank you for the detailed review. I integrated a lot of the suggested changes and merged the master branch with the new SRK server.
We probalby should resolve the confusion about runtimes and layers and how the SRK should handle them next.
docs/source/Examples/lambci.rst
Outdated
| $3 | ||
|
|
||
| As an example the following command will start a Python lambda function | ||
| container with data from the ``~/lambci`` directory. |
There was a problem hiding this comment.
Currently this is independent of SRK and must be setup manually. We should consider a deeper integration later on.
docs/source/Examples/lambci.rst
Outdated
| Using a custom runtime | ||
| ******************************************************************************* | ||
|
|
||
| To use a custom runtime, specify ``provided`` as runtime name for the |
There was a problem hiding this comment.
That's specific for AWS and LambCI (which mirrors AWS). It is the runtime name that must be specified if the actual runtime is provided via a layer. The "provided" runtime probably just passes through to the layer-provided runtime.
docs/source/Examples/lambci.rst
Outdated
|
|
||
| To use a custom runtime, specify ``provided`` as runtime name for the | ||
| ``lambci.sh`` script. The lambda container then expects a complete lambda | ||
| runtime in the ``runtime`` directory. For this, create a layer that contains |
There was a problem hiding this comment.
Yeah, there is some confusion about this term. Let's first discuss how the SRK should handle layers and custom runtimes and then move on to documentation.
There was a problem hiding this comment.
I've added #18 and #19 to document some future work to build on this PR. We don't need to boil the ocean here and this PR is too big already, I just don't want to forget.
There are some comments/change requests inline. A few more global notes:
- Document lambci and the new aws-lambda options in docs/source/Configuration.rst
- examples/requests needs a README. What does it do?
- We could probably move the whole shell package into the srk package (it already includes a bunch of utilities in pkg/srk/util.go
Overall I'm pretty happy with this now, it all makes sense.
|
Please see the update commit and my comments. |
|
@NathanTP please review - I've updated the documentation in accordance with your requests and merged the latest changes. |
This change adds custom runtime support and layers support to the awsLambda provider.