enhancements for AWS lambda #14
Conversation
|
Can you include documentation in docs/ for the user-visible aspects of these changes? At a minimum, it would help me in understanding what changes are being made here and the objectives of those changes. In particular: what are layers? |
|
Also, you may want to merge master, I made some changes to the docs in #13 |
Of course, thanks for the hint. Please have a look at https://docs.aws.amazon.com/lambda/latest/dg/configuration-layers.html regarding layers. I have to admit that I am not sure if I integrated the layers in the right way, but they are basically part of the function provider. If you have other ideas how to integrate them let me know. |
|
master is merged and I added a bit of documentation at Examples. |
There was a problem hiding this comment.
These changes seem mostly reasonable. The one high-level question that I have is whether we are approaching the addition of layers in the right way. At present it is 1:1 mapping with how they work in Lambda. I wonder whether this is right, or whether having multiple base images for the FaaS provider might be a better design. @NathanTP, I'd love to hear your thoughts on this. In the interest of keeping things moving I'm inclined to accept the current approach but maybe we should stay open to readdressing it.
| @@ -32,6 +32,6 @@ service : | |||
| # e.g. `arn:aws:iam::123459789012:role/service-role/my-service-role-ae04d032` | |||
| role : null | |||
| # Optional vpc/security-group setup to use. | |||
| # e.g.: "vpc-123456789abcdef,sg-123456789abcdef" | |||
| # e.g.: "subnet-8910f2f5,sg-123456789abcdef" | |||
There was a problem hiding this comment.
Let's not change this example.
|
closing PR as current version is #15 |
This branch debugs the AWS support and adds configuration of environment vars and layers.