Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: prevent compilation error on Node 12 (ref #1742) #1843

Merged
merged 1 commit into from Apr 25, 2019
Merged

fix: prevent compilation error on Node 12 (ref #1742) #1843

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
2 changes: 1 addition & 1 deletion packages/bindings/src/serialport.cpp
View file
Open in desktop
Expand Up @@ -38,7 +38,7 @@ NAN_METHOD(Open) {
Nan::ThrowTypeError("First argument must be a string");
return;
}
v8::String::Utf8Value path(Nan::To<v8::String>(info[0]).ToLocalChecked());
jacobq marked this conversation as resolved.
Show resolved Hide resolved
Nan::Utf8String path(info[0]);

// options
if (!info[1]->IsObject()) {
Expand Down