fix: prevent compilation error on Node 12 (ref #1742) #1843
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I think this fixes #1742 though it evidently breaks in Node v6.x |
|
Cc @indutny |
fivdi
reviewed
Apr 24, 2019
Without this, attempting to build against Node v12.0.0 on Linux leads to the below error:
```
../src/serialport.cpp: In function ‘Nan::NAN_METHOD_RETURN_TYPE Open(Nan::NAN_METHOD_ARGS_TYPE)’:
../src/serialport.cpp:41:75: error: no matching function for call to ‘v8::String::Utf8Value::Utf8Value(v8::Local<v8::String>)’
v8::String::Utf8Value path(Nan::To<v8::String>(info[0]).ToLocalChecked());
^
In file included from /home/user/.node-gyp/12.0.0/include/node/node.h:63:0,
from ../node_modules/nan/nan.h:53,
from ../src/./serialport.h:6,
from ../src/serialport.cpp:1:
/home/user/.node-gyp/12.0.0/include/node/v8.h:2995:5: note: candidate: v8::String::Utf8Value::Utf8Value(v8::Isolate*, v8::Local<v8::Value>)
Utf8Value(Isolate* isolate, Local<v8::Value> obj);
^~~~~~~~~
/home/user/.node-gyp/12.0.0/include/node/v8.h:2995:5: note: candidate expects 2 arguments, 1 provided
```
And attempting to build again Node v10.15.3 on Linux leads to the below warning:
```
../src/serialport.cpp:41:75: warning: ‘v8::String::Utf8Value::Utf8Value(v8::Local<v8::Value>)’ is deprecated: Use Isolate version [-Wdeprecated-declarations]
@serialport/bindings: v8::String::Utf8Value path(Nan::To<v8::String>(info[0]).ToLocalChecked());
@serialport/bindings: ^
@serialport/bindings: In file included from /home/user/.node-gyp/10.15.3/include/node/v8.h:26:0,
@serialport/bindings: from /home/user/.node-gyp/10.15.3/include/node/node.h:63,
@serialport/bindings: from ../node_modules/nan/nan.h:53,
@serialport/bindings: from ../src/./serialport.h:6,
@serialport/bindings: from ../src/serialport.cpp:1:
@serialport/bindings: /home/user/.node-gyp/10.15.3/include/node/v8.h:2892:28: note: declared here
@serialport/bindings: explicit Utf8Value(Local<v8::Value> obj));
```
jacobq
force-pushed
the
fix-path-conversion-for-node12
branch
from
eea40fd
to
79a8dfb
Compare
jacobq
changed the title
|
Note: Revised per @fivdi's suggestion. 🙏 This should circumvent the problem on node v6. 🤞 |
|
cool, Lets do it! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I think this fixes a slight oversight that prevents it from building against node v12.x but would appreciate review from someone more familiar with nan, v8, etc.
Without this, attempting to build against Node v12.0.0 on Linux leads to the below error:
And attempting to build again Node v10.15.3 on Linux leads to the below warning: