New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement Hash
for Number
.
#814
Merged
dtolnay
merged 11 commits into
serde-rs:master
from
timothee-haudebourg:hash-numbers-only
Nov 5, 2021
Merged
Changes from all commits
Commits
Show all changes
11 commits
Select commit
Hold shift + click to select a range
40ace5a
Impl`Eq+Hash` for `Number` using `ordered_float`.
be2f573
Do not show `NotNan` in `Number`'s `Debug` impl.
b59c0c0
Do not import always `NotNan`.
eec4e9d
Do not import `ordered_float` default features.
d153b88
Discard `ordered_float`, use custom `Hash` impl.
10655c7
Use `core::hash` instead of `std::hash`.
c3ac6c0
Manual implementation of `Number`'s `PartialEq`.
9046e3f
Avoid `Self::` for older Rust versions.
48393ab
Better justification for the use of `f64::to_bits`
d12fbb9
Fix `NaN` typo.
f53ae31
Use the same hash for +0 and -0.
File filter
Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
https://doc.rust-lang.org/1.56.0/std/hash/trait.Hash.html#hash-and-eq
Hash
has a documented requirement thatk1 == k2
implieshash(k1) == hash(k2)
, which this implementation violates.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Right, I forgot about that.