Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement Hash for Number. #814

Merged
merged 11 commits into from Nov 5, 2021
Merged

Implement Hash for Number. #814

merged 11 commits into from Nov 5, 2021

Commits on Oct 20, 2021

  1. ImplEq+Hash for Number using ordered_float.

    Timothée Haudebourg committed Oct 20, 2021
    Copy the full SHA
    40ace5a View commit details
    Browse the repository at this point in the history

  2. Do not show NotNan in Number's Debug impl.

    Timothée Haudebourg committed Oct 20, 2021
    Copy the full SHA
    be2f573 View commit details
    Browse the repository at this point in the history

  3. Do not import always NotNan. 

    Skip it when `arbitrary_precision` is enabled.
    Timothée Haudebourg committed Oct 20, 2021
    Copy the full SHA
    b59c0c0 View commit details
    Browse the repository at this point in the history

  4. Do not import ordered_float default features.

    Timothée Haudebourg committed Oct 20, 2021
    Copy the full SHA
    eec4e9d View commit details
    Browse the repository at this point in the history

  5. Discard ordered_float, use custom Hash impl.

    Timothée Haudebourg committed Oct 20, 2021
    Copy the full SHA
    d153b88 View commit details
    Browse the repository at this point in the history

  6. Use core::hash instead of std::hash.

    Timothée Haudebourg committed Oct 20, 2021
    Copy the full SHA
    10655c7 View commit details
    Browse the repository at this point in the history

  7. Manual implementation of Number's PartialEq. 

    To please clippy.
    Timothée Haudebourg committed Oct 20, 2021
    Copy the full SHA
    c3ac6c0 View commit details
    Browse the repository at this point in the history

  8. Avoid Self:: for older Rust versions. 

    Also fix a clippy warning.
    Timothée Haudebourg committed Oct 20, 2021
    Copy the full SHA
    9046e3f View commit details
    Browse the repository at this point in the history

  9. Better justification for the use of f64::to_bits

    Timothée Haudebourg committed Oct 20, 2021
    Copy the full SHA
    48393ab View commit details
    Browse the repository at this point in the history

  10. Fix NaN typo.

    Timothée Haudebourg committed Oct 20, 2021
    Copy the full SHA
    d12fbb9 View commit details
    Browse the repository at this point in the history

Commits on Nov 5, 2021

  1. Use the same hash for +0 and -0.

    Timothée Haudebourg committed Nov 5, 2021
    Copy the full SHA
    f53ae31 View commit details
    Browse the repository at this point in the history