Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(snowflake): Adding nonexistent tableExistsQuery to snowflake dialect query generator #14930

Merged
merged 4 commits into from Sep 17, 2022

Conversation

sfc-gh-dgadomski
Copy link
Contributor

@sfc-gh-dgadomski sfc-gh-dgadomski commented Aug 24, 2022

Pull Request Checklist

Please make sure to review and check all of these items:

  • Have you added new tests to prevent regressions?
  • Does yarn test or yarn test-DIALECT pass with this change (including linting)?
  • Is a documentation update included (if this change modifies existing APIs, or introduces new ones)?
  • Did you update the typescript typings accordingly (if applicable)?
  • Does the description below contain a link to an existing issue (Closes #[issue]) or a description of the issue you are solving?
  • Did you follow the commit message conventions explained in CONTRIBUTING.md?

Description Of Change

Starting from version 6.20.0 a new method tableExistsQuery is introduced and used by the sequelizesync method. Unfortunately this method is implemented in all dialects except snowflake. This causes snowflake dialect basically unusable. This PR fixes the issue by adding the implementation of tableExistsQuery in snowlake dialect.

@WikiRik
Copy link
Member

WikiRik commented Aug 24, 2022

Thanks for the PR! Unfortunately we do not have access to a snowflake instance to run integration tests so we are dependent on the community for that. We can run the unit tests of course so thanks for adding those here.

We'll review this soon

@sfc-gh-dgadomski sfc-gh-dgadomski changed the title fix(snowflake) Adding nonexistent tableExistsQuery to snowflake dialect query generator fix(snowflake): Adding nonexistent tableExistsQuery to snowflake dialect query generator Aug 24, 2022
@WikiRik WikiRik requested a review from jesse23 August 25, 2022 16:51
Copy link
Member

@WikiRik WikiRik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As mentioned before we cannot run integration tests but this change looks good to me. Can you make an additional PR to the v6 branch so we can land it there as well?

@ephys ephys merged commit eedba90 into sequelize:main Sep 17, 2022
@github-actions
Copy link
Contributor

🎉 This PR is included in version 7.0.0-alpha.17 🎉

The release is available on:

Your semantic-release bot 📦🚀

@sfc-gh-dgadomski
Copy link
Contributor Author

Thanks for merging it. I've just created another PR into v6 branch: #15087

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants