Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Increase weight of funded PRs #27

Merged
merged 3 commits into from Oct 5, 2022
Merged

Increase weight of funded PRs #27

merged 3 commits into from Oct 5, 2022

Conversation

sdepold
Copy link
Member

@sdepold sdepold commented Oct 3, 2022

With this PR, we increase the importance and weight of implementing funded work. Each PR that is labelled with "funded" will be scored 5 times higher than normal PRs or 10 times higher than a commented PR.

@sdepold
Copy link
Member Author

sdepold commented Oct 3, 2022

Before:

Overall stats
-------------
WikiRik: 43% (total: 83, pr: 60, issues: 0, comments: 23)
fzn0x: 21% (total: 41, pr: 34, issues: 0, comments: 7)
ephys: 17% (total: 34, pr: 18, issues: 0, comments: 16)
sdepold: 7% (total: 14, pr: 8, issues: 0, comments: 6)
mmkal: 5% (total: 10, pr: 8, issues: 0, comments: 2)
evanrittenhouse: 3% (total: 6, pr: 4, issues: 0, comments: 2)
sushantdhiman: 2% (total: 4, pr: 4, issues: 0, comments: 0)

After:

Overall stats
-------------
WikiRik: 42% (total: 91, pr: 68, issues: 0, comments: 23)
fzn0x: 18% (total: 41, pr: 34, issues: 0, comments: 7)
ephys: 15% (total: 34, pr: 18, issues: 0, comments: 16)
sdepold: 13% (total: 30, pr: 24, issues: 0, comments: 6)
mmkal: 4% (total: 10, pr: 8, issues: 0, comments: 2)
evanrittenhouse: 2% (total: 6, pr: 4, issues: 0, comments: 2)
sushantdhiman: 1% (total: 4, pr: 4, issues: 0, comments: 0)

Currently only 2 of my PRs are marked as funded. That means we reduce 2 * 2 points from my score and add 2 * 10 == 6 + (8-4+20) = 30

@sdepold sdepold requested review from ephys and WikiRik October 4, 2022 06:36
@WikiRik
Copy link
Member

WikiRik commented Oct 4, 2022

Would it be possible to extend the list of users to include all users that have worked on funded issues? Or do we want to give them a separate bounty?

@sdepold
Copy link
Member Author

sdepold commented Oct 4, 2022

You mean non-team members?

@WikiRik
Copy link
Member

WikiRik commented Oct 4, 2022

Yup!

@sdepold
Copy link
Member Author

sdepold commented Oct 4, 2022

So that we could hand out money to "outsiders"? I guess for that we would need to change the fundamental approach of the script since it is currently starting from our team and finds data for the members. I didn't even consider this approach so far. :D

@sdepold
Copy link
Member Author

sdepold commented Oct 4, 2022

Fine with merging this without the other users?

@sdepold
Copy link
Member Author

sdepold commented Oct 4, 2022

I guess we can extend it if concrete need arises?

@WikiRik
Copy link
Member

WikiRik commented Oct 4, 2022

Sure!

@sdepold
Copy link
Member Author

sdepold commented Oct 4, 2022

@WikiRik I just added support for "external" people and treat them as if they would be team members.
For testing purposes, I added the label funded to sequelize/sequelize#15087 hence we see 10 points for this and another 2 for sequelize/sequelize#14930

Overall stats
-------------
WikiRik: 40% (total: 92, pr: 68, issues: 0, comments: 24)
fzn0x: 17% (total: 41, pr: 34, issues: 0, comments: 7)
ephys: 14% (total: 34, pr: 18, issues: 0, comments: 16)
sdepold: 13% (total: 30, pr: 24, issues: 0, comments: 6)
sfc-gh-dgadomski: 5% (total: 12, pr: 12, issues: 0, comments: 0)
mmkal: 4% (total: 10, pr: 8, issues: 0, comments: 2)
evanrittenhouse: 2% (total: 6, pr: 4, issues: 0, comments: 2)
sushantdhiman: 1% (total: 4, pr: 4, issues: 0, comments: 0)

@sdepold sdepold requested a review from WikiRik October 4, 2022 18:42
Copy link
Member

@WikiRik WikiRik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I looked through it quickly and seems good. It also works for you so that helps

@sdepold sdepold merged commit c2e3cb4 into main Oct 5, 2022
@sdepold sdepold deleted the feature/priority-work branch October 5, 2022 06:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants