Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(types): fix QueryInterface#bulkInsert attribute arg type #13945

Merged
merged 9 commits into from Jan 14, 2022
Merged

fix(types): fix QueryInterface#bulkInsert attribute arg type #13945

Show file tree
Hide file tree
Changes from 3 commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
ed02de9
fix(types): fix type for bulkInsert 4th arg
ChristopherChudzicki Jan 13, 2022
138c125
fix(types): make JSON and JSONB constructable
ChristopherChudzicki Jan 13, 2022
b958c2d
Merge branch 'main' into bulk-insert-types
WikiRik Jan 13, 2022
7ff90cb
fix(types): fix JSON type constuctor
ChristopherChudzicki Jan 13, 2022
52c2200
fix(types): more JSON type fixes + tests
ChristopherChudzicki Jan 13, 2022
6a1c3e5
fix(types): add test for queryInterface.bulkInsert
ChristopherChudzicki Jan 13, 2022
fc32704
fix(types): date data type interface
ChristopherChudzicki Jan 13, 2022
4676a8d
fix(types): make abstract data type constructable
ChristopherChudzicki Jan 13, 2022
6d45875
fix(types): add a few more type tests
ChristopherChudzicki Jan 13, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
10 changes: 6 additions & 4 deletions types/lib/data-types.d.ts
View file
Open in desktop
Expand Up @@ -366,13 +366,15 @@ export const HSTORE: AbstractDataTypeConstructor;
/**
* A JSON string column. Only available in postgres.
*/
export const JSON: AbstractDataTypeConstructor;

export interface JSON extends AbstractDataTypeConstructor {
new (): JSON;
}
/**
* A pre-processed JSON data column. Only available in postgres.
*/
export const JSONB: AbstractDataTypeConstructor;

export interface JSONB extends AbstractDataTypeConstructor {
new (): JSONB;
}
/**
* A default value of the current timestamp
*/
Expand Down
2 changes: 1 addition & 1 deletion types/lib/query-interface.d.ts
View file
Open in desktop
Expand Up @@ -497,7 +497,7 @@ export class QueryInterface {
tableName: TableName,
records: object[],
options?: QueryOptions,
attributes?: string[] | string
attributes?: Record<string, ModelAttributeColumnOptions>
): Promise<object | number>;

/**
Expand Down