Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(types): fix QueryInterface#bulkInsert attribute arg type #13945

Merged
merged 9 commits into from Jan 14, 2022
Merged

fix(types): fix QueryInterface#bulkInsert attribute arg type #13945

merged 9 commits into from Jan 14, 2022

Commits on Jan 13, 2022

  1. fix(types): fix type for bulkInsert 4th arg

    @ChristopherChudzicki
    ChristopherChudzicki committed Jan 13, 2022
    Copy the full SHA
    ed02de9 View commit details
    Browse the repository at this point in the history

  2. fix(types): make JSON and JSONB constructable 

    An alternative to this might be to give `AbstractDataTypeConstructor` a constructor method, along the lines of:

```ts
interface AbstractDataTypeConstructor {
  new (): AbstractDataType;
  key: string;
  warn(link: string, text: string): void;
}
```

Then all the types would become constructable. Is that desirable?
    @ChristopherChudzicki
    ChristopherChudzicki committed Jan 13, 2022
    Copy the full SHA
    138c125 View commit details
    Browse the repository at this point in the history

  3. Merge branch 'main' into bulk-insert-types

    @WikiRik
    WikiRik committed Jan 13, 2022
    Copy the full SHA
    b958c2d View commit details
    Browse the repository at this point in the history

  4. fix(types): fix JSON type constuctor 

    to return AbstractDataType not AbstractDataTypeConstructor
    @ChristopherChudzicki
    ChristopherChudzicki committed Jan 13, 2022
    Copy the full SHA
    7ff90cb View commit details
    Browse the repository at this point in the history

  5. fix(types): more JSON type fixes + tests

    @ChristopherChudzicki
    ChristopherChudzicki committed Jan 13, 2022
    Copy the full SHA
    52c2200 View commit details
    Browse the repository at this point in the history

  6. fix(types): add test for queryInterface.bulkInsert

    @ChristopherChudzicki
    ChristopherChudzicki committed Jan 13, 2022
    Copy the full SHA
    6a1c3e5 View commit details
    Browse the repository at this point in the history

  7. fix(types): date data type interface 

    should extend AbstractDataType not AbstractDataTypeConstructor
    @ChristopherChudzicki
    ChristopherChudzicki committed Jan 13, 2022
    Copy the full SHA
    fc32704 View commit details
    Browse the repository at this point in the history

  8. fix(types): make abstract data type constructable

    @ChristopherChudzicki
    ChristopherChudzicki committed Jan 13, 2022
    Copy the full SHA
    4676a8d View commit details
    Browse the repository at this point in the history

  9. fix(types): add a few more type tests 

    for the types affected by new constructor signature on AbstractDataType
    @ChristopherChudzicki
    ChristopherChudzicki committed Jan 13, 2022
    Copy the full SHA
    6d45875 View commit details
    Browse the repository at this point in the history