Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ci(windows): added windows to the os matrix #2659

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from
Draft

ci(windows): added windows to the os matrix #2659

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
5 changes: 4 additions & 1 deletion .github/workflows/test.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,8 +19,11 @@ jobs:
node-version:
- 18.0.0
- 19
os:
- ubuntu-latest
- windows-latest
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The integration test can not run on Windows server due to limitations. The CI run can exclude the integration test. Add after line 24 as part of strategy:

        include:
          - os: windows-latest
            sr-no-test: "!test/integration.test.js"
            sr-test: "test/**/*.test.js"

Add to line 40 to exclude the integration test:

    - run: npm run test:ci -- ${{matrix.sr-test}} ${{matrix.sr-no-test}}

This has been tested in another repo workflow that checks out semantic-release.


runs-on: ubuntu-latest
runs-on: "${{ matrix.os }}"

steps:
- uses: actions/checkout@v3
Expand Down