ci(windows): added windows to the os matrix #2659
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
in hopes of reproducing #2658
|
A quibble PR 89 has been opened for the Windows test failures. |
The PR has been merged and there is a new release of quibble. |
webstech
reviewed
Mar 4, 2023
| @@ -19,8 +19,11 @@ jobs: | |||
| node-version: | |||
| - 18.0.0 | |||
| - 19 | |||
| os: | |||
| - ubuntu-latest | |||
| - windows-latest | |||
There was a problem hiding this comment.
The integration test can not run on Windows server due to limitations. The CI run can exclude the integration test. Add after line 24 as part of strategy:
include:
- os: windows-latest
sr-no-test: "!test/integration.test.js"
sr-test: "test/**/*.test.js"
Add to line 40 to exclude the integration test:
- run: npm run test:ci -- ${{matrix.sr-test}} ${{matrix.sr-no-test}}
This has been tested in another repo workflow that checks out semantic-release.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
in hopes of reproducing #2658