Preventing double-hashing for TikTok Offline Conversions. #2034
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nick-Ag
approved these changes
May 14, 2024
|
hi @jae-rhee-tiktok - a Solution Architect from Segment just raised this PR while I was on PTO. |
joe-ayoub-segment
added
partner-eng-review (cloud)
and removed
Ready for Release
labels
3 tasks
|
hi @jae-rhee-tiktok thanks for reviewing and approving that other PR. This PR does something similar for the Offline Conversions Destination. Are you OK for us to deploy this? |
|
hi @joe-ayoub-segment, the change for offline destination looks good as well! Thank you! |
joe-ayoub-segment
approved these changes
May 27, 2024
joe-ayoub-segment
deleted the
tiktok-offline-conversions-prevent-double-hashing
branch
|
hi @seg-leonelsanches PR deployed. Please check it all looks good! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It prevents double-hashing for email and phone when these traits are already hashed (SHA256).
Testing