Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Preventing double-hashing for TikTok Conversions. #2033

Merged
merged 1 commit into from
May 28, 2024

Conversation

seg-leonelsanches
Copy link
Contributor

It prevents double-hashing for email and phone when these traits are already hashed (SHA256).

Testing

  • Added unit tests for new functionality
  • Tested end-to-end using the local server
  • [Segmenters] Tested in the staging environment

@joe-ayoub-segment
Copy link
Contributor

hi @jae-rhee-tiktok - any chance you could take a look at this PR please? It was raised by @seg-leonelsanches from the Segment Solution Architect team. Is it something we should deploy?

@jae-rhee-tiktok
Copy link
Contributor

hi @joe-ayoub-segment thank you for the update.

The change looks good to prevent double hashing. Is it common for clients to hash the values before sending them to Segment?

@seg-leonelsanches
Copy link
Contributor Author

hi @joe-ayoub-segment thank you for the update.

The change looks good to prevent double hashing. Is it common for clients to hash the values before sending them to Segment?

Hi @jae-rhee-tiktok 👋

Yes, our financial sector customers can't send plain data to Segment regarding PII such as email and phone. It's the same for #2034.

@jae-rhee-tiktok
Copy link
Contributor

hi @joe-ayoub-segment thank you for the update.
The change looks good to prevent double hashing. Is it common for clients to hash the values before sending them to Segment?

Hi @jae-rhee-tiktok 👋

Yes, our financial sector customers can't send plain data to Segment regarding PII such as email and phone. It's the same for #2034.

@seg-leonelsanches nice to meet you! The changes look good. @joe-ayoub-segment can we merge this? Thank you!

@joe-ayoub-segment joe-ayoub-segment merged commit 1c71987 into main May 28, 2024
11 checks passed
@joe-ayoub-segment joe-ayoub-segment deleted the tiktok-conversion-prevent-double-hashing branch May 28, 2024 09:06
@joe-ayoub-segment
Copy link
Contributor

hi @seg-leonelsanches PR deployed. Please check it all looks good!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
5 participants