Support ESLint 8.x #73
Conversation
I believe the only remaining incompatibility is with the Cypress plugin. This shouldn't be a blocker as we still support ESLint 7.x in theory.
| parser: '@babel/eslint-parser', | ||
| parserOptions: { | ||
| babelOptions: { | ||
| presets: ['@babel/preset-react'], | ||
| }, | ||
| requireConfigFile: false, |
There was a problem hiding this comment.
| @@ -118,7 +121,7 @@ const baseConfig = { | |||
| extends: [ | |||
| 'plugin:@typescript-eslint/eslint-recommended', | |||
| 'plugin:@typescript-eslint/recommended', | |||
| 'prettier/@typescript-eslint', | |||
| 'prettier', | |||
There was a problem hiding this comment.
| sourceType: 'module', | ||
| ecmaFeatures: { jsx: true }, |
There was a problem hiding this comment.
JSX support is encapsulated in the React preset
| @@ -137,7 +140,6 @@ const baseConfig = { | |||
| ERROR, | |||
| { ignoreParameters: true }, | |||
| ], | |||
| '@typescript-eslint/explicit-module-boundary-types': OFF, | |||
There was a problem hiding this comment.
Removed from the recommended rule set typescript-eslint/typescript-eslint#3746
|
Would appreciate eyes on this one @seek-oss/sku-maintainers. This seems to work fine for skuba and a couple sku apps I tested via Yarn resolution override, but you'll have a more holistic view. There's a beta published: https://github.com/seek-oss/eslint-config-seek/releases/tag/v9.0.0-beta.0 The TypeScript ESLint bump should allow us to upgrade to newer TypeScript versions without an annoying warning being printed to the terminal. |
package.json
Outdated
| "find-root": "^1.1.0" | ||
| }, | ||
| "devDependencies": { | ||
| "@changesets/cli": "2.17.0", | ||
| "@changesets/get-github-info": "0.5.0", | ||
| "eslint": "^7.14.0", | ||
| "eslint": "7.32.0", |
There was a problem hiding this comment.
Shouldn't this be 8 now? Realise it's a dev dep.
Co-authored-by: Matt Jones <mjones@seek.com.au>
I believe the only remaining incompatibility is with the Cypress plugin. This shouldn't be a blocker as we still support ESLint 7.x in theory.
Closes #62.