migrate babel-eslint to @babel/eslint-parser #65
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
72636c
reviewed
Oct 28, 2021
| 'eslint-config-seek': minor | ||
| --- | ||
|
|
||
| migrated babel-eslint to @babel/eslint-parser |
There was a problem hiding this comment.
Can we provide more context here? For example, are there any changes/gotchas in the parser that consumers should be aware of?
| extends: [ | ||
| 'plugin:css-modules/recommended', |
There was a problem hiding this comment.
This appears to be confuddled with #64. Can you rebase this PR on the default branch and only include the Babel changes?
| @@ -100,9 +101,8 @@ const baseConfig = { | |||
| version: '>16', | |||
| }, | |||
| }, | |||
| plugins: ['react', 'react-hooks', 'css-modules'], | |||
| plugins: ['react', 'react-hooks', '@babel'], | |||
There was a problem hiding this comment.
It looks like we didn't declare this plugin before. What are the implications of adding it?
|
Stale and superseded by #73 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removed babel-eslint
Added
@babel/eslint-parserand its dependency@babel/coreand its rule companion@babel/eslint-pluginAs part of the eslint8 support changes mentioned in #62