Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CI: fix tests on Windows #591

Merged
merged 1 commit into from Aug 5, 2023
Merged

CI: fix tests on Windows #591

merged 1 commit into from Aug 5, 2023

Conversation

azu
Copy link
Member

@azu azu commented Aug 5, 2023

azu
azu commented Aug 5, 2023
View reviewed changes
.github/workflows/test.yml
Comment on lines -24 to 27
runs-on: ubuntu-latest
runs-on: ${{matrix.os}}
strategy:
matrix:
os: [ macos-latest, windows-latest, ubuntu-latest ]
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This CI workflow did not work on Windows…
https://github.com/secretlint/secretlint/tree/master/packages/secretlint/test/snapshots/secretlintignore
https://github.com/secretlint/secretlint/blob/master/packages/secretlint/test/cli.test.ts

@azu azu changed the title CI: fix to test on Windows CI: fix tests on Windows Aug 5, 2023
@azu azu mentioned this pull request Aug 5, 2023
Merged
@azu azu merged commit 229cca7 into master Aug 5, 2023
4 of 16 checks passed
@azu azu deleted the windows-test branch August 5, 2023 06:43
@azu
Copy link
Member Author

azu commented Aug 5, 2023

@azu azu added the Type: CI Changes to CI configuration files and scripts label Aug 5, 2023
@github-actions github-actions bot mentioned this pull request Aug 5, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Type: CI Changes to CI configuration files and scripts
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@azu