Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve modal component error handling #289

Merged
merged 10 commits into from
Aug 6, 2020
Merged

Improve modal component error handling #289

merged 10 commits into from
Aug 6, 2020

Commits on Aug 6, 2020

  1. refactor: convert inert functionality into a single method

    @sebnitu
    sebnitu committed Aug 6, 2020
    Configuration menu
    Copy the full SHA
    0297b7d View commit details
    Browse the repository at this point in the history

  2. test: fix tests

    @sebnitu
    sebnitu committed Aug 6, 2020
    Configuration menu
    Copy the full SHA
    35e004f View commit details
    Browse the repository at this point in the history

  3. refactor: rename setOverflow to setOverflowHidden

    @sebnitu
    sebnitu committed Aug 6, 2020
    Configuration menu
    Copy the full SHA
    69e7433 View commit details
    Browse the repository at this point in the history

  4. refactor: remove redundant api to method setting

    @sebnitu
    sebnitu committed Aug 6, 2020
    Configuration menu
    Copy the full SHA
    82f2d3a View commit details
    Browse the repository at this point in the history

  5. feat: add modal not found error to open function

    @sebnitu
    sebnitu committed Aug 6, 2020
    Configuration menu
    Copy the full SHA
    20b7b4f View commit details
    Browse the repository at this point in the history

  6. refactor: add better promise error handling

    @sebnitu
    sebnitu committed Aug 6, 2020
    Configuration menu
    Copy the full SHA
    ef57258 View commit details
    Browse the repository at this point in the history

  7. refactor: use more consistent function names

    @sebnitu
    sebnitu committed Aug 6, 2020
    Configuration menu
    Copy the full SHA
    1888dd8 View commit details
    Browse the repository at this point in the history

  8. refactor: better organize functions and api definitions

    @sebnitu
    sebnitu committed Aug 6, 2020
    Configuration menu
    Copy the full SHA
    74a7a61 View commit details
    Browse the repository at this point in the history

  9. docs: update docs with option changes

    @sebnitu
    sebnitu committed Aug 6, 2020
    Configuration menu
    Copy the full SHA
    f77b1f3 View commit details
    Browse the repository at this point in the history

  10. chore: run build

    @sebnitu
    sebnitu committed Aug 6, 2020
    Configuration menu
    Copy the full SHA
    02a3356 View commit details
    Browse the repository at this point in the history