Improve modal component error handling #289
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Currently there is no error handling when the open method is called with a key that doesn't return a modal.
Solution
This PR introduces a promise rejection for when a modal key doesn't return a modal element. This work also cleans up and refactors function names and api definition positions. The following options names have been changed:
selectorMain
→selectorInert
- to better match the intent of this setting.toggleOverflow
→selectorOverflow
- to better match the intent of this setting.