Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix modal hidden focusable bug #280

Merged
merged 16 commits into from
Aug 2, 2020
Merged

Fix modal hidden focusable bug #280

merged 16 commits into from
Aug 2, 2020

Commits on Aug 2, 2020

  1. fix: pass open as a callback to close preventing early memory wipe

    @sebnitu
    sebnitu committed Aug 2, 2020
    Configuration menu
    Copy the full SHA
    a825324 View commit details
    Browse the repository at this point in the history

  2. refactor: take advantage of open/close promises instead of callbacks

    @sebnitu
    sebnitu committed Aug 2, 2020
    Configuration menu
    Copy the full SHA
    6619548 View commit details
    Browse the repository at this point in the history

  3. breaking: remove open and close callbacks in favor of promises

    @sebnitu
    sebnitu committed Aug 2, 2020
    Configuration menu
    Copy the full SHA
    71703ac View commit details
    Browse the repository at this point in the history

  4. refactor: open and close transitions now return the modal

    @sebnitu
    sebnitu committed Aug 2, 2020
    Configuration menu
    Copy the full SHA
    fff6b7b View commit details
    Browse the repository at this point in the history

  5. refactor: update open and close transitions to use async syntax

    @sebnitu
    sebnitu committed Aug 2, 2020
    Configuration menu
    Copy the full SHA
    719dafc View commit details
    Browse the repository at this point in the history

  6. docs: add dialog component to examples

    @sebnitu
    sebnitu committed Aug 2, 2020
    Configuration menu
    Copy the full SHA
    0c528a5 View commit details
    Browse the repository at this point in the history

  7. fix: add focusable test to remove hidden elements from memory

    @sebnitu
    sebnitu committed Aug 2, 2020
    Configuration menu
    Copy the full SHA
    91ecb14 View commit details
    Browse the repository at this point in the history

  8. docs: update example styles

    @sebnitu
    sebnitu committed Aug 2, 2020
    Configuration menu
    Copy the full SHA
    58e4c18 View commit details
    Browse the repository at this point in the history

  9. fix: corrects promise usage with open/close flow

    @sebnitu
    sebnitu committed Aug 2, 2020
    Configuration menu
    Copy the full SHA
    e4ed3a2 View commit details
    Browse the repository at this point in the history

  10. refactor: add back eventListener instead of setTimeout for transitions

    @sebnitu
    sebnitu committed Aug 2, 2020
    Configuration menu
    Copy the full SHA
    d178a24 View commit details
    Browse the repository at this point in the history

  11. feat: add working var to catch spam requests

    @sebnitu
    sebnitu committed Aug 2, 2020
    Configuration menu
    Copy the full SHA
    b1db63c View commit details
    Browse the repository at this point in the history

  12. chore: remove debug focus styles

    @sebnitu
    sebnitu committed Aug 2, 2020
    Configuration menu
    Copy the full SHA
    fa19cea View commit details
    Browse the repository at this point in the history

  13. refactor: move prevent default to happen earlier

    @sebnitu
    sebnitu committed Aug 2, 2020
    Configuration menu
    Copy the full SHA
    2ca0dff View commit details
    Browse the repository at this point in the history

  14. test: add test coverage for new features

    @sebnitu
    sebnitu committed Aug 2, 2020
    Configuration menu
    Copy the full SHA
    4f2c8c4 View commit details
    Browse the repository at this point in the history

  15. chore: run build

    @sebnitu
    sebnitu committed Aug 2, 2020
    Configuration menu
    Copy the full SHA
    a9a4c13 View commit details
    Browse the repository at this point in the history

  16. docs: update docs regarding callbacks and promises

    @sebnitu
    sebnitu committed Aug 2, 2020
    Configuration menu
    Copy the full SHA
    3961d7f View commit details
    Browse the repository at this point in the history