Fix modal hidden focusable bug #280
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
There's a bug that allows tab to escape the modal when the first or last focusable elements are hidden via CSS.
Solution
This PR extracts the focusable array build into it's own method and includes a focus test. This also created the need to fire open and close sequentially so there was a refactor introducing promises so that an open call only happens after a close is complete. The impacts how opening modals from inside other modals works. Because of this refactor, it removes the need for callbacks since you can now wait for the promises to resolve. Lastly, a "working" check is done on click so that it's no longer possible to trigger a new modal open if one is in the middle of transitioning.