Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Always print seed used for --order-by=random #3524

Merged
merged 2 commits into from Feb 7, 2019
Merged

Always print seed used for --order-by=random #3524

merged 2 commits into from Feb 7, 2019

Conversation

epdenouden
Copy link
Contributor

@epdenouden epdenouden commented Feb 7, 2019

Fix #3515 by combining randomness and predictability ☯️

@codecov
Copy link

codecov bot commented Feb 7, 2019

Codecov Report

Merging #3524 into 7.5 will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff            @@
##                7.5    #3524   +/-   ##
=========================================
  Coverage     83.39%   83.39%           
  Complexity     3623     3623           
=========================================
  Files           143      143           
  Lines          9648     9648           
=========================================
  Hits           8046     8046           
  Misses         1602     1602
Impacted Files Coverage Δ Complexity Δ
src/TextUI/TestRunner.php 68.16% <100%> (ø) 293 <0> (ø) ⬇️
src/Runner/Version.php 66.66% <0%> (ø) 8% <0%> (ø) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2896657...9c3cc15. Read the comment docs.

@sebastianbergmann sebastianbergmann merged commit 890a226 into sebastianbergmann:7.5 Feb 7, 2019
@epdenouden epdenouden deleted the issue-3515-always-print-random-seed branch February 8, 2019 10:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants