Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Run test suite with executionOrder="random" #3450

Closed
wants to merge 1 commit into from

Conversation

Majkl578
Copy link
Contributor

@Majkl578 Majkl578 commented Feb 6, 2019

Q A
Type improvement
BC Break no
Fixed issues #3449

Copy link
Member

@Ocramius Ocramius left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The fact that all builds went completely haywire is quite telling: I'd love to have this merged though.

Is there any way to make sure that the random seed is displayed in the build? That's a real blocker.

@Majkl578
Copy link
Contributor Author

Majkl578 commented Feb 9, 2019

@Ocramius Yes, see sebastianbergmann/phpunit#3515 + sebastianbergmann/phpunit#3524 - the seed will be displayed by default in the next PHPUnit release. 👍

@@ -650,7 +652,7 @@
"homepage": "https://nette.org/contributors"
}
],
"description": "💎 Nette Dependency Injection Container: Flexible, compiled and full-featured DIC with perfectly usable autowiring and support for all new PHP 7.1 features.",
"description": "? Nette Dependency Injection Container: Flexible, compiled and full-featured DIC with perfectly usable autowiring and support for all new PHP 7.1 features.",
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks like a composer bug on Windows.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did you run the update on Windows? 😱

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes. 😹 Composer should be portable, right? 😅

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Apparently, it's not only a Windows issue. I'm getting the same consistently on one of my two Linux machines (see #3604). Did you have a chance to look deeper or maybe report an issue? I haven't found anything related.

@Majkl578 Majkl578 requested a review from morozov April 13, 2019 12:02
@morozov
Copy link
Member

morozov commented Apr 13, 2019

While we are fixing the failures, let's try to document what the end result should like from the CI perspective. IIRC, we considered running PR tests with a fixed seed in order to avoid irrelevant failures. The question is, what if a PR introduces an implicit dependency? Should cron-scheduled builds and the push ones have the same order settings? Or we just go wild and enable the random order everywhere?

@morozov morozov removed their request for review October 23, 2020 16:44
Base automatically changed from master to 4.0.x January 22, 2021 07:44
@morozov
Copy link
Member

morozov commented Aug 2, 2021

Closing in favor of #4731. There are no more known failures in failures in random mode but there doesn't seem to be a way to allow build failures on GitHub Actions for a certain configuration.

@morozov morozov closed this Aug 2, 2021
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 3, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants