Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix inefficient loop in getHookMethods and save up to 4% in cachegrind files #3429

Closed
wants to merge 1 commit into from
Closed

fix inefficient loop in getHookMethods and save up to 4% in cachegrind files #3429

wants to merge 1 commit into from

Commits on Nov 30, 2018

  1. this commit is the result of finding a significant bottleneck in cach… 

    …egrind files

and performance gain up to 4% is measured in testsuites (of local projects).

It fixes an inefficient loop in getHookMethods in which unnecessary logic can be executed
when method docblock are are not defined. It also minimizes calls to the same methods.

Also, the code is verbose enough to understand without the need for extra private methods.
    @dynasource
    dynasource committed Nov 30, 2018
    Copy the full SHA
    7107dbb View commit details
    Browse the repository at this point in the history