fix inefficient loop in getHookMethods and save up to 4% in cachegrind files #3429
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #3429 +/- ##
============================================
- Coverage 82.29% 82.28% -0.02%
+ Complexity 3569 3565 -4
============================================
Files 143 143
Lines 9376 9370 -6
============================================
- Hits 7716 7710 -6
Misses 1660 1660
Continue to review full report at Codecov.
|
|
Can you please send this against |
…egrind files and performance gain up to 4% is measured in testsuites (of local projects). It fixes an inefficient loop in getHookMethods in which unnecessary logic can be executed when method docblock are are not defined. It also minimizes calls to the same methods. Also, the code is verbose enough to understand without the need for extra private methods.
dynasource
force-pushed
the
fix_performance_getHookMethods
branch
from
3c7aa92
to
7107dbb
Compare
sebastianbergmann
added
the
type/enhancement
|
Merged manually, thanks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this commit is the result of finding a significant bottleneck in cachegrind files and performance gain up to 4% (measured in a project)
It fixes an inefficient loop in getHookMethods in which unnecessary logic can be executed when method docblock are not defined. It also minimizes calls to the same methods.
Also, the code is verbose enough to understand without the need for extra private methods.