Bump flask from 2.1.3 to 2.2.2

[dependabot]

Bumps flask from 2.1.3 to 2.2.2.

Release notes

Sourced from flask's releases.

2.2.2

This is a fix release for the 2.2.0 feature release.

• Changes: https://flask.palletsprojects.com/en/2.2.x/changes/#version-2-2-1
• Milestone: https://github.com/pallets/flask/milestone/25?closed=1

2.2.1

This is a fix release for the 2.2.0 feature release.

• Changes: https://flask.palletsprojects.com/en/2.2.x/changes/#version-2-2-1
• Milestone: https://github.com/pallets/flask/milestone/23?closed=1

2.2.0

This is a feature release, which includes new features and removes previously deprecated code. The 2.2.x branch is now the supported bug fix branch, the 2.1.x branch will become a tag marking the end of support for that branch. We encourage everyone to upgrade, and to use a tool such as pip-tools to pin all dependencies and control upgrades.

• Changes: https://flask.palletsprojects.com/en/2.2.x/changes/#version-2-2-0
• Milestone: https://github.com/pallets/flask/milestone/19?closed=1

Changelog

Sourced from flask's changelog.

Version 2.2.2

Released 2022-08-08

• Update Werkzeug dependency to >= 2.2.2. This includes fixes related to the new faster router, header parsing, and the development server. :pr:4754
• Fix the default value for app.env to be "production". This attribute remains deprecated. :issue:4740

Version 2.2.1

Released 2022-08-03

• Setting or accessing json_encoder or json_decoder raises a deprecation warning. :issue:4732

Version 2.2.0

Released 2022-08-01

• Remove previously deprecated code. :pr:4667

  • Old names for some send_file parameters have been removed. download_name replaces attachment_filename, max_age replaces cache_timeout, and etag replaces add_etags. Additionally, path replaces filename in send_from_directory.
  • The RequestContext.g property returning AppContext.g is removed.

• Update Werkzeug dependency to >= 2.2.

• The app and request contexts are managed using Python context vars directly rather than Werkzeug's LocalStack. This should result in better performance and memory use. :pr:4682

  • Extension maintainers, be aware that _app_ctx_stack.top and _request_ctx_stack.top are deprecated. Store data on g instead using a unique prefix, like g._extension_name_attr.

• The FLASK_ENV environment variable and app.env attribute are deprecated, removing the distinction between development and debug mode. Debug mode should be controlled directly using the --debug option or app.run(debug=True). :issue:4714

... (truncated)

Commits

• a1c478b Merge pull request #4755 from pallets/release-2.2.2
• 43d2fff release version 2.2.2
• e9af7c2 Merge pull request #4754 from pallets/werkzeug-version
• de16718 require werkzeug >= 2.2.2
• 6ab3cb8 fix issue number
• e3eaafb Merge pull request #4749 from pallets/shell-env
• e3df233 remove env from shell banner
• a0458ef refactor or remove old docs (#4748)
• 45b2c99 Merge pull request #4742 from pallets/env-default
• a6a7a57 fix default value of app.env
• Additional commits viewable in compare view

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.

---

Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

• @dependabot rebase will rebase this PR
• @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
• @dependabot merge will merge this PR after your CI passes on it
• @dependabot squash and merge will squash and merge this PR after your CI passes on it
• @dependabot cancel merge will cancel a previously requested merge and block automerging
• @dependabot reopen will reopen this PR if it is closed
• @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
• @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
• @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
• @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

[return42]

Before merge, see

• Bump flask from 2.1.3 to 2.2.1 #1616 (comment)
• Bump flask from 2.1.3 to 2.2.1 #1616 (comment)

[dalf]

• hostname_replace works.
• FLASK_APP is still documented: https://flask.palletsprojects.com/en/2.2.x/cli/

So LGTM.

[return42]

• FLASK_APP is still documented: https://flask.palletsprojects.com/en/2.2.x/cli/

The #1616 (comment) was more about FLASK_ENV

• deprecate FLASK_ENV and app.env pallets/flask#4720
• deprecate FLASK_ENV pallets/flask#4714

You suggested #1616 (comment) .. would you like to open a issue or a PR from your suggestion? .. or is it no more needed?

[dalf]

True, this is about FLASK_ENV not FLASK_APP.

I've made some tests.

With Flask 2.1.3 and 2.2.2:

• FLASK_APP=searx.webapp flask run --reload does the initialization twice on the first run, so the code is useless.
• SEARXNG_DEBUG=1 FLASK_APP=searx.webapp flask run --reload does the initialization twice too.
• SEARXNG_DEBUG=1 FLASK_APP=searx.webapp flask run does not reload the server when there is a code change.
• SEARXNG_DEBUG=1 FLASK_APP=searx.webapp FLASK_ENV=development flask run works as expected : debug and reload.

With the last command line, there is a warning:
'FLASK_ENV' is deprecated and will not be used in Flask 2.3. Use 'FLASK_DEBUG' instead.

So to update the current (broken*) code:

searxng/searx/webapp.py

Lines 1381 to 1383 in e81c458

	flask_run_development = (
	os.environ.get("FLASK_APP") is not None and os.environ.get("FLASK_ENV") == 'development' and is_flask_run_cmdline()
	)

should be replaced by:

os.environ.get("FLASK_APP") is not None and (os.environ.get("FLASK_ENV") == 'development' or os.environ.get("FLASK_DEBUG") not in {"0", "false", "no"} ) and is_flask_run_cmdline()

As long we don't that, the initialization steps are going to be done twice when users starts the app with SEARXNG_DEBUG=1 FLASK_APP=searx.webapp FLASK_DEBUG=1 flask run. It is an edge case AFIK.

---

broken because --reload does the initialization twice.

[return42]

Thanks for detail description ..

It is an edge case AFIK.

Are the use cases of such "edge cases" needs to be supported? .. if not we can "clean up the code". AFAIK all we need to support is:

SEARXNG_DEBUG=1 pyenv.cmd python -m searx.webapp

What should restart the WEB-App on (python) code changes. Additional we can also rebuild JS & CSS on theme modifications:

LIVE_THEME=1 make run

So my question remain, should we (I) send a PR or open an issue to "clean up the code"?