Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump tokio from 0.2 to 0.3 #741

Closed
wants to merge 11 commits into from

Conversation

Urhengulas
Copy link

@Urhengulas Urhengulas commented Nov 6, 2020

Bump tokio and related dependencies (hyper, tokio-rustls, tokio-tungstenite).

Checklist

Fixes #725

Cargo.toml Outdated Show resolved Hide resolved
@Urhengulas
Copy link
Author

Urhengulas commented Nov 7, 2020

Currently breaking and complaining that traits are note implemented although they should be.. Do I miss some import statement or feature-flag?

cc @seanmonstar @nickelc

  1. tokio::io::async_read::AsyncRead is not implemented for tokio::fs::File
    error[E0277]: the trait bound `tokio::fs::File: tokio::io::async_read::AsyncRead` is not satisfied
       --> src/filters/fs.rs:423:38
        |
    423 |                 let n = match ready!(poll_read_buf(Pin::new(&mut f), cx, &mut buf)) {
        |                                      ^^^^^^^^^^^^^ the trait `tokio::io::async_read::AsyncRead` is not implemented for `tokio::fs::File`
        | 
       ::: /home/urhengulas/.cargo/git/checkouts/tokio-377c595163f99a10/c2e843d/tokio-util/src/lib.rs:106:29
        |
    106 |     pub fn poll_read_buf<T: AsyncRead, B: BufMut>(
        |                             --------- required by this bound in `tokio_util::io::poll_read_buf`
    
                                        ^^^^^^^^^^^^^ the trait `tokio::io::async_read::AsyncRead` is not implemented for `tokio::fs::File`
    
  2. bytes::buf::buf_mut::BufMut is not implemented for bytes::BytesMut
    error[E0277]: the trait bound `bytes::BytesMut: bytes::buf::buf_mut::BufMut` is not satisfied
       --> src/filters/fs.rs:423:74
        |
    423 |                 let n = match ready!(poll_read_buf(Pin::new(&mut f), cx, &mut buf)) {
        |                                                                          ^^^^^^^^ the trait `bytes::buf::buf_mut::BufMut` is not implemented for `bytes::BytesMut`
        | 
       ::: /home/urhengulas/.cargo/git/checkouts/tokio-377c595163f99a10/c2e843d/tokio-util/src/lib.rs:106:43
        |
    106 |     pub fn poll_read_buf<T: AsyncRead, B: BufMut>(
        |  
    

@jxs
Copy link
Collaborator

jxs commented Nov 8, 2020

Currently breaking and complaining that traits are note implemented although they should be.. Do I miss some import statement or feature-flag?

it's probably because of bytes version mismatch, tokio is already using version 0.6, also see hyperium/hyper#2323

@Urhengulas
Copy link
Author

Currently breaking and complaining that traits are note implemented although they should be.. Do I miss some import statement or feature-flag?

it's probably because of bytes version mismatch, tokio is already using version 0.6, also see hyperium/hyper#2323

@jxs: Ahh okay. So I guess the plan is to update bytes to 0.6 for warp and hyper, right?

ebkalderon added a commit to ebkalderon/ukama-coding-assignment that referenced this pull request Nov 27, 2020
Unfortunately, `warp` doesn't support `tokio` 0.3.X yet.

seanmonstar/warp#741
@Urhengulas
Copy link
Author

Superseeded by #753

@Urhengulas Urhengulas closed this Dec 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Upgrade to Tokio v1
3 participants