New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bump tokio-util from 0.3.1 to 0.5.0 #6680
Conversation
@zekun000 :D this something you can take on? |
And if not, who in networking should? |
I'll look in to it since I don't expect much action otherwise, but shouldn't networking/consensus take ownership of the tokio crate? |
Pinging @phlip9 from networking. |
I think it's likely too early to try to get this in. Too many other deps require tokio and mismatches seems to occur. |
23f6438
to
8a41e77
Compare
why? |
They are the main consumers of tokio. The dev-infra team does not have the bandwidth to carefully manage every dependency. We need to spread this load over all of the core infra team. |
I don't disagree with spreading the load and happy to help, but that doesn't affect the ownership. async is a fundamental piece of the language, if devinfra is responsible for rust, it probably should own tokio. |
This might be a bit early, we probably need to wait for some of our dependencies to update:
Edit: possibly also some more since the bytes crate updated to v0.6.0. |
Agreed, we need to wait till more of the ecosystem has updated |
c839d49
to
48c6504
Compare
10d6d12
to
4bbb323
Compare
This PR made the following dependency changes: Added Packages (Duplicate versions in '()'):
bytes 0.6.0 (0.5.6)
pin-project-lite 0.2.0 (0.1.11)
tokio 0.3.5 (0.2.22)
tokio-util 0.5.0 (0.3.1)
|
Bumps [tokio-util](https://github.com/tokio-rs/tokio) from 0.3.1 to 0.5.0. - [Release notes](https://github.com/tokio-rs/tokio/releases) - [Commits](tokio-rs/tokio@tokio-0.3.1...tokio-util-0.5.0) Signed-off-by: dependabot[bot] <support@github.com>
4bbb323
to
f28d0ce
Compare
release binaries dependency change summary:
|
Superseded by #6804. |
Bumps tokio-util from 0.3.1 to 0.5.0.
Release notes
Sourced from tokio-util's releases.
Commits
24ed874
chore: prepare tokio-util v0.5.0 release (#3078)3965d91
util: update to bytes 0.6 (#3071)a3ef4e4
util: deduplicate implementations of poll_read_buf() (#3064)34eb47d
runtime: block_on should NOT be called from async context (#3070)c8a484b
tokio: remove unused dependency (#3063)9097ae5
chore: prepare v0.3.2 release (#3059)d786553
Revert "util: upgrade tokio-util to bytes 0.6 (#3052)" (#3060)38605c5
net: change mention of net2 (#3056)fe2b997
util: upgrade tokio-util to bytes 0.6 (#3052)6d0ba19
sync: make oneshot::Sender::poll_closed public again (#3032)Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting
@dependabot rebase
.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebase
will rebase this PR@dependabot recreate
will recreate this PR, overwriting any edits that have been made to it@dependabot merge
will merge this PR after your CI passes on it@dependabot squash and merge
will squash and merge this PR after your CI passes on it@dependabot cancel merge
will cancel a previously requested merge and block automerging@dependabot reopen
will reopen this PR if it is closed@dependabot close
will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually