Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump tokio-util from 0.3.1 to 0.5.0 #6680

Closed
wants to merge 1 commit into from

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Nov 10, 2020

Bumps tokio-util from 0.3.1 to 0.5.0.

Release notes

Sourced from tokio-util's releases.

Tokio v0.3.3

Fixes a soundness hole by adding a missing Send bound to Runtime::spawn_blocking().

Fixed

  • rt: include missing Send, fixing soundness hole (#3089).
  • tracing: avoid huge trace span names (#3074).

Added

  • net: TcpSocket::reuseport(), TcpSocket::set_reuseport() (#3083).
  • net: TcpSocket::reuseaddr() (#3093).
  • net: TcpSocket::local_addr() (#3093).
  • net: add pid to UCred (#2633).

Tokio v0.3.2

Adds AsyncFd as a replacement for v0.2's PollEvented.

Fixed

  • io: fix a potential deadlock when shutting down the I/O driver (#2903).
  • sync: RwLockWriteGuard::downgrade() bug (#2957).

Added

  • io: AsyncFd for receiving readiness events on raw FDs (#2903).
  • net: poll_* function on UdpSocket (#2981).
  • net: UdpSocket::take_error() (#3051).
  • sync: oneshot::Sender::poll_closed() (#3032).
Commits

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually

@dependabot dependabot bot added cargo dependencies Pull requests that update a dependency file labels Nov 10, 2020
@bors-libra bors-libra added this to In Review in bors Nov 10, 2020
@rexhoffman
Copy link
Contributor

@zekun000 :D this something you can take on?

@rexhoffman
Copy link
Contributor

And if not, who in networking should?

@zekun000
Copy link
Contributor

maybe @bmwill or @metajack ?

@rexhoffman
Copy link
Contributor

I'll look in to it since I don't expect much action otherwise, but shouldn't networking/consensus take ownership of the tokio crate?

@metajack
Copy link
Contributor

Pinging @phlip9 from networking.

@rexhoffman
Copy link
Contributor

I think it's likely too early to try to get this in. Too many other deps require tokio and mismatches seems to occur.

@dependabot dependabot bot force-pushed the dependabot/cargo/tokio-util-0.5.0 branch from 23f6438 to 8a41e77 Compare November 12, 2020 18:20
@zekun000
Copy link
Contributor

but shouldn't networking/consensus take ownership of the tokio crate?

why?

@metajack
Copy link
Contributor

They are the main consumers of tokio.

The dev-infra team does not have the bandwidth to carefully manage every dependency. We need to spread this load over all of the core infra team.

@zekun000
Copy link
Contributor

I don't disagree with spreading the load and happy to help, but that doesn't affect the ownership. async is a fundamental piece of the language, if devinfra is responsible for rust, it probably should own tokio.

@phlip9
Copy link
Contributor

phlip9 commented Nov 13, 2020

This might be a bit early, we probably need to wait for some of our dependencies to update:

Edit: possibly also some more since the bytes crate updated to v0.6.0.
Edit: rusoto is only used by cluster-test, so it's probably not blocking us.

@bmwill
Copy link
Contributor

bmwill commented Nov 16, 2020

This might be a bit early, we probably need to wait for some of our dependencies to update:

Edit: possibly also some more since the bytes crate updated to v0.6.0

Agreed, we need to wait till more of the ecosystem has updated

@dependabot dependabot bot force-pushed the dependabot/cargo/tokio-util-0.5.0 branch 2 times, most recently from c839d49 to 48c6504 Compare November 18, 2020 00:44
@dependabot dependabot bot force-pushed the dependabot/cargo/tokio-util-0.5.0 branch 2 times, most recently from 10d6d12 to 4bbb323 Compare December 1, 2020 22:21
@cargo-dep-bot
Copy link

cargo-dep-bot bot commented Dec 1, 2020

This PR made the following dependency changes:

Added Packages (Duplicate versions in '()'):
	bytes 0.6.0 (0.5.6)
	pin-project-lite 0.2.0 (0.1.11)
	tokio 0.3.5 (0.2.22)
	tokio-util 0.5.0 (0.3.1)

Bumps [tokio-util](https://github.com/tokio-rs/tokio) from 0.3.1 to 0.5.0.
- [Release notes](https://github.com/tokio-rs/tokio/releases)
- [Commits](tokio-rs/tokio@tokio-0.3.1...tokio-util-0.5.0)

Signed-off-by: dependabot[bot] <support@github.com>
@dependabot dependabot bot force-pushed the dependabot/cargo/tokio-util-0.5.0 branch from 4bbb323 to f28d0ce Compare December 3, 2020 22:36
@libra-action
Copy link

release binaries dependency change summary:

target packages:
  A tokio-util 0.5.0 (direct third-party, crates.io)
    * features: codec, compat, default, futures-io
  A bytes 0.6.0 (transitive third-party, crates.io) (other versions: 0.5.6)
    * features: default, std
  A tokio 0.3.5 (transitive third-party, crates.io) (other versions: 0.2.22)
    * features: default, futures-core, stream
  M tokio-util 0.3.1 (transitive third-party, crates.io)
    * status changed from direct third-party
    * removed features: compat, futures-io
    * (unchanged features: codec, default)

@dependabot @github
Copy link
Contributor Author

dependabot bot commented on behalf of github Dec 4, 2020

Superseded by #6804.

@dependabot dependabot bot closed this Dec 4, 2020
@bors-libra bors-libra removed this from In Review in bors Dec 4, 2020
@dependabot dependabot bot deleted the dependabot/cargo/tokio-util-0.5.0 branch December 4, 2020 03:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cargo cla-signed dependencies Pull requests that update a dependency file deps-changed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants