Implement tower Service for Client #1420
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mathspy
force-pushed
the
impl-service-for-client
branch
from
1f74d4f
to
76f611f
Compare
seanmonstar
reviewed
Apr 20, 2022
Cargo.toml
Outdated
| @@ -56,6 +56,8 @@ json = ["serde_json"] | |||
|
|
|||
| multipart = ["mime_guess"] | |||
|
|
|||
| tower = ["tower-service"] | |||
There was a problem hiding this comment.
I don't think we need to make this optional, hyper already depends on it.
Mathspy
force-pushed
the
impl-service-for-client
branch
from
76f611f
to
1166499
Compare
seanmonstar
approved these changes
Apr 20, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Is this something desirable? This requires exposing
Pendingwhich seemed to have been hidden intentionally, is that an okay thing to do?It's pretty straightforward and would help issues like #491 by letting people easily wrap the client in tower services for rate limiting and other desirable functionalities