Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add request limit handling #1

Closed
bugproof opened this issue Jul 14, 2021 · 1 comment
Closed

Add request limit handling #1

bugproof opened this issue Jul 14, 2021 · 1 comment
Labels
good first issue Good for newcomers help wanted Extra attention is needed

Comments

@bugproof
Copy link
Owner

bugproof commented Jul 14, 2021 •
edited

The default limit is 100 requests per minute. Honestly I have no idea how to implement this in a nice way... Should send method return a custom BaseLinkerError when the limit is exceeded or just wait/delay?

The limit should be configurable

Related issues:

seanmonstar/reqwest#491
seanmonstar/reqwest#1420
@bugproof bugproof added help wanted Extra attention is needed good first issue Good for newcomers labels Jul 14, 2021
@bugproof
Copy link
Owner Author

Implemented in ac7ed99 using tower for now. Possibly look at other rate limiting crates like governor.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue Good for newcomers help wanted Extra attention is needed
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@bugproof