Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Re-export env_logger's optional features #42

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

shesek
Copy link

@shesek shesek commented Nov 9, 2020

Re-export the atty, humantime and regex features. Some time-related features are disabled without humantime.

I did not make termcolor optional because it seemed too interleaved with pretty_env_logger's code, and because I'm not sure it would still justify the name without this. (-:

The biggest gain is eliminating the the regex feature/dependency, which I noticed was adding 1.1MB to my stripped release build .so file.

The default behavior remains the same with everything enabled.

@shesek
Copy link
Author

shesek commented Nov 9, 2020

I just now noticed #42 and #28 which suggest basically the same. Should've checked sooner >_<

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant