Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add (enabled by default) regex feature and update env-logger to 0.8 #35

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

jakobhellermann
Copy link

see #28.
I don't think disabling color is that useful because at that point you can just use env_logger directly, so I just added a feature for regex.

@lnicola
Copy link

lnicola commented Oct 20, 2020

This needs to be updated to 0.8, but besides that is there anything that could move it forward, @seanmonstar?

@jakobhellermann jakobhellermann changed the title add (enabled by default) regex feature add (enabled by default) regex feature and update env-logger to 0.8 Oct 20, 2020
@jakobhellermann
Copy link
Author

done 👍

@holly-hacker
Copy link

@seanmonstar can this PR or #42 be looked into? I want to use pretty-env-logger in a project but pulling in the entire regex crate is a big no-no.

@shesek
Copy link

shesek commented Mar 24, 2021

I'm also finding the regex crate dependency to be challenging. I swallowed the bullet but it increases my binary size by 30%.

There's another variation of this PR by myself at #42. Anything that I could do to help make it happen?

I know it's not much, but I subscribed as a GH sponsor to show some appreciation for hyper, warp, reqwest and many of your other projects that I'm using extensively. Thank you :)

@lnicola
Copy link

lnicola commented Mar 27, 2021

TBH, I think the crate is small enough that you can fork/vendor and modify/make a new one based on it.

@ibraheemdev
Copy link

@seanmonstar can this be merged?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants