Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add 3rd party generated completion fallbacks #905

Merged
merged 15 commits into from Mar 26, 2023
Merged

feat: add 3rd party generated completion fallbacks #905

Changes from 1 commit
Commits
Show all changes
15 commits
Select commit Hold shift + click to select a range
d1a2999
feat(__load_completion): localize default `$IFS`
scop Mar 23, 2023
77f2c6b
refactor: refer to underscore prefixed files as "fallback"
scop Mar 23, 2023
f402bf0
feat(gh): add fallback 3rd party completion loader
scop Mar 23, 2023
363b9fc
feat(golangci-lint): add fallback 3rd party completion loader
scop Mar 23, 2023
031e317
feat(hugo): add fallback 3rd party completion loader
scop Mar 23, 2023
f4e3109
feat(upctl): add fallback 3rd party completion loader
scop Mar 23, 2023
ef651f8
feat(sshi): add fallback 3rd party completion loader
scop Mar 23, 2023
3a1103e
feat(vacuum): add fallback 3rd party completion loader
scop Mar 23, 2023
3c1947b
feat(yq): add fallback 3rd party completion loader
scop Mar 23, 2023
d27b144
feat(ruff): add fallback 3rd party completion loader
scop Mar 23, 2023
8610d7d
feat(rustup): add fallback 3rd party completion loader
scop Mar 23, 2023
7cd9cb9
feat(cargo): add fallback 3rd party completion loader
scop Mar 23, 2023
5618654
feat(__load_completion): pass backslashless command to fallback loads
scop Mar 23, 2023
328ecf7
feat(kn): add fallback 3rd party completion loader
scop Mar 23, 2023
43da208
refactor: use `eval` instead of tweaking POSIX mode in 3rd party loaders
scop Mar 26, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
2 changes: 1 addition & 1 deletion bash_completion
View file
Open in desktop
Expand Up @@ -2567,7 +2567,7 @@ __load_completion()
# Do not warn with . or .. (especially the former is common)
[[ $compfile == */.?(.) ]] ||
echo "bash_completion: $compfile: is a directory" >&2
elif [[ -e $compfile ]] && . "$compfile"; then
elif [[ -e $compfile ]] && . "$compfile" "$cmd"; then
Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess this is something we could consider adding a test for, but I'm not sure if it's worth the trouble.

Also not sure about adding tests for the the actual completions as their result varies depending on if the generating command is installed or not.

[[ $backslash ]] && $(complete -p "$cmd") "\\$cmd"
return 0
fi
Expand Down