feat: add 3rd party generated completion fallbacks #905
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In order to be able to wrap loading 3rd party completions in enable+reset posix mode. #904 (comment)
They are not always necessarily deprecated, but can serve as fallbacks due to other reasons.
scop
commented
Mar 23, 2023
So that things work also for commands preceded by a backslash. Co-authored-by: Koichi Murase <myoga.murase@gmail.com>
scop
commented
Mar 23, 2023
| @@ -2567,7 +2567,7 @@ __load_completion() | |||
| # Do not warn with . or .. (especially the former is common) | |||
| [[ $compfile == */.?(.) ]] || | |||
| echo "bash_completion: $compfile: is a directory" >&2 | |||
| elif [[ -e $compfile ]] && . "$compfile"; then | |||
| elif [[ -e $compfile ]] && . "$compfile" "$cmd"; then | |||
There was a problem hiding this comment.
I guess this is something we could consider adding a test for, but I'm not sure if it's worth the trouble.
Also not sure about adding tests for the the actual completions as their result varies depending on if the generating command is installed or not.
Per the note in CONTRIBUTING.md, #905 (comment)
akinomyoga
approved these changes
Mar 26, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Per #904