Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump eslint-plugin-import from 2.22.1 to 2.23.2 #731

Closed

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github May 17, 2021

Bumps eslint-plugin-import from 2.22.1 to 2.23.2.

Release notes

Sourced from eslint-plugin-import's releases.

v2.23.0

https://github.com/benmosher/eslint-plugin-import/blob/v2.23.0/CHANGELOG.md#2230---2021-05-13

Changelog

Sourced from eslint-plugin-import's changelog.

[2.23.2] - 2021-05-15

Changed

  • [meta] add safe-publish-latest; use prepublishOnly script for npm 7+

[2.23.1] - 2021-05-14

Fixed

[2.23.0] - 2021-05-13

Added

Fixed

Changed

  • [Generic Import Callback] Make callback for all imports once in rules (#1237, thanks [@​ljqx])
  • [Docs] [no-named-as-default]: add semicolon (#1897, thanks [@​bicstone])
  • [Docs] no-extraneous-dependencies: correct peerDependencies option default to true (#1993, thanks [@​dwardu])
  • [Docs] order: Document options required to match ordering example (#1992, thanks [@​silviogutierrez])
  • [Tests] no-unresolved: add tests for import() (#2012, thanks [@​davidbonnet])
  • [Docs] Add import/recommended ruleset to README (#2034, thanks [@​edemaine])
Commits
  • a332f20 Bump to v2.23.2
  • 5af181f [meta] add safe-publish-latest; use prepublishOnly script for npm 7+
  • 8431b46 Bump to v2.23.1
  • 83f3c3e [Fix] order: fix alphabetical sorting
  • 8213543 [Tests] add missing fixture from d903477f4e31be71e016f8af56cbe2a8d4f11c9c
  • d903477 [Fix] ExportMap: do not crash when tsconfig lacks .compilerOptions
  • dd0e8cb [meta] correct #2065 -> #2056
  • 8d7ec17 [Fix] newline-after-import: fix crash with export {} syntax
  • e9e755d Bump to v2.23.0
  • 7b264c0 [resolvers/webpack] v0.13.1
  • Additional commits viewable in compare view

Dependabot compatibility score

You can trigger a rebase of this PR by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

@dependabot dependabot bot added dependencies Pull requests that update a dependency file javascript Pull requests that update Javascript code labels May 17, 2021
@giorgiosironi
Copy link
Collaborator

giorgiosironi commented May 19, 2021

A couple of problems:

  • @types/... packages should be listed in the project's dependencies, not devDependencies. True at least for all types of dependencies packages
  • import/order changed behavior so it will reorder a few import statements in 2 files that have import type declarations.

@giorgiosironi
Copy link
Collaborator

npm install @types/pg --save-prod moves the package in the right place, but also accidentally changes the version of its dependencies:

diff --git a/package-lock.json b/package-lock.json
index c3a5ef74..c97fd8e2 100644
--- a/package-lock.json
+++ b/package-lock.json
@@ -1633,7 +1633,6 @@
       "version": "7.14.11",
       "resolved": "https://registry.npmjs.org/@types/pg/-/pg-7.14.11.tgz",
       "integrity": "sha512-EnZkZ1OMw9DvNfQkn2MTJrwKmhJYDEs5ujWrPfvseWNoI95N8B4HzU/Ltrq5ZfYxDX/Zg8mTzwr6UAyTjjFvXA==",
-      "dev": true,
       "requires": {
         "@types/node": "*",
         "pg-protocol": "^1.2.0",
@@ -13675,10 +13674,9 @@
       "integrity": "sha512-0O5huCql8/D6PIRFAlmccjphLYWC+JIzvUhSzXSpGaf+tjTZc4nn+Lr7mLXBbFJfvwbP0ywDv73EiaBsxn7zdg=="
     },
     "pg-protocol": {
-      "version": "1.4.0",
-      "resolved": "https://registry.npmjs.org/pg-protocol/-/pg-protocol-1.4.0.tgz",
-      "integrity": "sha512-El+aXWcwG/8wuFICMQjM5ZSAm6OWiJicFdNYo+VY3QP+8vI4SvLIWVe51PppTzMhikUJR+PsyIFKqfdXPz/yxA==",
-      "dev": true
+      "version": "1.5.0",
+      "resolved": "https://registry.npmjs.org/pg-protocol/-/pg-protocol-1.5.0.tgz",
+      "integrity": "sha512-muRttij7H8TqRNu/DxrAJQITO4Ac7RmX3Klyr/9mJEOBeIpgnF8f9jAfRz5d3XwQZl5qBjF9gLsUtMPJE0vezQ=="
     },
     "pg-types": {
       "version": "2.2.0",

@giorgiosironi
Copy link
Collaborator

import-js/eslint-plugin-import#2078 states this is a regression of the library. Generally speaking @types are devDependencies as they are not needed at runtime, only at build time.

@giorgiosironi
Copy link
Collaborator

@dependabot ignore this minor version

@dependabot dependabot bot closed this May 19, 2021
@dependabot @github
Copy link
Contributor Author

dependabot bot commented on behalf of github May 19, 2021

OK, I won't notify you about version 2.23.x again, unless you re-open this PR or update to a 2.23.x release yourself.

@dependabot dependabot bot deleted the dependabot/npm_and_yarn/eslint-plugin-import-2.23.2 branch May 19, 2021 11:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file javascript Pull requests that update Javascript code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant