Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[patch] no-extraneous-dependencies: Add package.json cache #1948

Merged
merged 1 commit into from Nov 19, 2020

Conversation

fa93hws
Copy link
Contributor

@fa93hws fa93hws commented Nov 18, 2020

This rule is super slow in our code base, and it seems it invoke one IO request for every single file..

@fa93hws
Copy link
Contributor Author

fa93hws commented Nov 18, 2020

image

WSL failures seem unrelated?

Copy link
Member

@ljharb ljharb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems reasonable, thanks!

@ljharb ljharb changed the title chore: Add package.json cache to no-extraneous-dependencies rule [patch] no-extraneous-dependencies: Add package.json cache Nov 18, 2020
@coveralls
Copy link

coveralls commented Nov 18, 2020

Coverage Status

Coverage increased (+0.004%) to 97.909% when pulling 8c1a65d on fa93hws:fa93hws/extr-dep/cache into dd4e416 on benmosher:master.

@ljharb ljharb merged commit 8c1a65d into import-js:master Nov 19, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants