Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Synchronize metadata driver setup with upstream changes #933

Merged
merged 1 commit into from Dec 8, 2023

Conversation

mbabker
Copy link
Contributor

@mbabker mbabker commented Aug 3, 2023

Q A
Bug fix? no
New feature? yes
Doc updated no
BC breaks? no
Deprecations? no
Tests pass? yes
Fixed tickets N/A
License MIT

This synchronizes the metadata driver setup with changes in the core library, accounting for:

@goetas
Copy link
Collaborator

goetas commented Aug 3, 2023

I guess that this needs a new tag in the serializer library and it should require only that in the composer.json, right?

@goetas
Copy link
Collaborator

goetas commented Aug 28, 2023

@mbabker https://github.com/schmittjoh/serializer/releases/tag/3.28.0 has been tagged, this will allow you to require 3.28.0 and use easily the latest changes you made

"jms/serializer": "^3.20",
"jms/metadata": "^2.5",
"jms/serializer": "^3.28",
"jms/metadata": "^2.6",
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The bump on the metadata package isn't strictly needed, but the serializer package has this as its minimum so figured I'd change it to match.

@mbabker
Copy link
Contributor Author

mbabker commented Aug 28, 2023

this will allow you to require 3.28.0 and use easily the latest changes you made

PR's updated.

@ruudk
Copy link
Contributor

ruudk commented Dec 7, 2023

@goetas @mbabker Anything needed to get this merged? Tests are green ✅ 🙏

@goetas goetas merged commit 2be38ab into schmittjoh:master Dec 8, 2023
8 checks passed
@mbabker mbabker deleted the sync-with-lib branch January 29, 2024 14:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants