Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

EventDispatcher - use case sensitive event names; #695

Merged
merged 2 commits into from Nov 12, 2018
Merged

EventDispatcher - use case sensitive event names; #695

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
2cb36ae
EventDispatcher - use case sensitive event names;
gam6itko Nov 12, 2018
a34c75e
EventSubscribersAndListenersPassTest fix
gam6itko Nov 12, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
4 changes: 2 additions & 2 deletions DependencyInjection/Compiler/RegisterEventListenersAndSubscribersPass.php
View file
Open in desktop
Expand Up @@ -22,7 +22,7 @@ public function process(ContainerBuilder $container)
}

$class = isset($attributes['class'])
? strtolower($container->getParameterBag()->resolveValue($attributes['class']))
? $container->getParameterBag()->resolveValue($attributes['class'])
: null;

$format = isset($attributes['format']) ? $attributes['format'] : null;
Expand Down Expand Up @@ -52,7 +52,7 @@ public function process(ContainerBuilder $container)
throw new \RuntimeException(sprintf('The service "%s" (class: %s) must return an event for each subscribed event.', $id, $subscriberClass));
}

$class = isset($eventData['class']) ? strtolower($eventData['class']) : null;
$class = isset($eventData['class']) ? $eventData['class'] : null;
$format = isset($eventData['format']) ? $eventData['format'] : null;
$method = isset($eventData['method']) ? $eventData['method'] : EventDispatcher::getDefaultMethodName($eventData['event']);
$priority = isset($eventData['priority']) ? (integer)$eventData['priority'] : 0;
Expand Down
6 changes: 3 additions & 3 deletions Tests/DependencyInjection/EventSubscribersAndListenersPassTest.php
View file
Open in desktop
Expand Up @@ -121,7 +121,7 @@ public function testEventListener()
'serializer.pre_serialize' => [
[
['my_listener', 'onserializerpreserialize'],
'bar',
'Bar',
null
]
]], $call[1][0]);
Expand Down Expand Up @@ -161,7 +161,7 @@ public function testEventListenerWithParams()
'serializer.pre_serialize' => [
[
['my_listener', 'onserializerpreserialize'],
'bar',
'Bar',
null
]
]], $call[1][0]);
Expand Down Expand Up @@ -196,7 +196,7 @@ public function testEventSubscriber()
'serializer.pre_serialize' => [
[
['my_listener', 'onserializerpreserialize'],
'bar',
'Bar',
'json',
null
]
Expand Down