Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

EventDispatcher - use case sensitive event names; #695

Merged
merged 2 commits into from Nov 12, 2018
Merged

EventDispatcher - use case sensitive event names; #695

merged 2 commits into from Nov 12, 2018

Conversation

gam6itko
Copy link
Contributor

You forgot to adapt CompilerPass for changes in commit below.

schmittjoh/serializer@d0cf4cb#diff-f5a58b28905e2b53063b7633beb9e605

@goetas
Copy link
Collaborator

goetas commented Nov 12, 2018

Thanks for your PR, can you can a look at the tests? it looks they are failing

@goetas goetas added the bug label Nov 12, 2018
@gam6itko
Copy link
Contributor Author

gam6itko commented Nov 12, 2018

Done. But I don't know why checks haven’t completed yet.

@goetas goetas merged commit 37d9568 into schmittjoh:master Nov 12, 2018
@goetas
Copy link
Collaborator

goetas commented Nov 12, 2018

Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants