To aid cross building, allow ? as a wildcard even without -Xsource:3
#9990
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Like scala#9721, the goal here is to ease cross-compilation between Scala 2 and 3 code as we prepare for `_` as wildcard to be deprecated in Scala 3 (cf scala/scala3#5379). This is technically a source-breaking change, but using a type named ? without backticks is deprecated since 2.13.6 (scala#9626) and defining a type named ? without backticks is disallowed since 2.13.7 (scala#9735). The only known user of ? as a type name was the kind-projector plugin, but support for this syntax was removed from the plugin a year ago (typelevel/kind-projector#186), so I believe this change won't be disruptive.
|
SGTM. @dwijnand, @SethTisue? |
dwijnand
approved these changes
Apr 6, 2022
Any opinion on this before I open a PR? |
|
I'm happy with that plan. |
smarter
added a commit
to smarter/scala
that referenced
this pull request
Apr 18, 2022
This backports scala#9990 to Scala 2.12 as discussed in that PR.
This was referenced Apr 18, 2022
|
opened typelevel/kind-projector#210 to notify the kind-projector folks |
|
I've opened a PR to temporarily revert scalameta/scalameta#2733 until 2.12.16 and 2.13.9 are released, as source code generation is now broken for all releases in the 2.12 and 2.13 lines. Once the releases are cut, there's a follow-up PR to reintroduce the new Broadcasting intent here, in case others run into the same issue I did, no longer being able to generate code that compiles with the currently released latest versions of either 2.12 or 2.13. |
SethTisue
changed the title
SethTisue
changed the title
? as a wildcard even without -Xsource:3
This was referenced Dec 30, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Like #9721, the goal here is to ease cross-compilation between Scala 2 and 3 code as we prepare for
_as wildcard to be deprecated in Scala 3 (cf scala/scala3#5379).This is technically a source-breaking change, but using a type named
?without backticks is deprecated since 2.13.6 (#9626) and defining a type named?without backticks is disallowed since 2.13.7 (#9735). The only known user of?as a type name was the kind-projector plugin, but support for this syntax was removed from the plugin a year ago (typelevel/kind-projector#186), so I believe this change won't be disruptive.