Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow ? as placeholder as default in Scala213 and Scala212 dialects #2734

Merged
merged 1 commit into from Apr 20, 2022

Conversation

tgodzik
Copy link
Collaborator

@tgodzik tgodzik commented Apr 20, 2022

Fixes #2733

@tgodzik tgodzik requested review from dos65 and kitbellew April 20, 2022 17:34
@kitbellew
Copy link
Contributor

@tgodzik change is simple but... why? scala213 does not really support it.

@tgodzik
Copy link
Collaborator Author

tgodzik commented Apr 20, 2022

@tgodzik change is simple but... why? scala213 does not really support it.

It's due to scala/scala#9990

We could add a separate dialect, but it would be too much hassle and the change only influences [?] which will not break anything that wasn't allowed before.

@tgodzik tgodzik merged commit ae9f68d into scalameta:main Apr 20, 2022
@tgodzik tgodzik deleted the default-question branch April 20, 2022 18:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

? will be allowed as a wildcard by default in Scala 2.13.9 and 2.12.16
2 participants