loosen unicode directional character check #10030
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
as per discussion on scala#10017, we were flagging too many characters. a false positive came up in the community build; I modified the test case to include it.
SethTisue
added
prio:blocker
|
labeled "internal" since this fixes code that hadn't been released yet |
This was referenced May 9, 2022
lrytz
approved these changes
May 9, 2022
sjrd
approved these changes
May 9, 2022
SethTisue
removed
the
prio:blocker
danarmak
added a commit
to danarmak/scala
that referenced
this pull request
Oct 21, 2022
…source files Update documentation with changes made in scala#10017, scala#10023, scala#10030
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
as per discussion on #10017, we were flagging too many characters. a false positive came up in the community build; I modified the test case to include it.