For security, error on source files with Unicode directional formatting characters #10017
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SethTisue
added
release-notes
|
@sjrd could you maybe review this? |
som-snytt
approved these changes
Apr 26, 2022
sjrd
requested changes
Apr 27, 2022
Don't allow characters with unicode property `Bidi_Class` in source files.
sjrd
approved these changes
Apr 27, 2022
|
Backport to 2.12 is not trivial because 2.12 eagerly interpretes |
|
I guess just let any escapes pass on 2.12, just error if the codepoints appear in the file. |
SethTisue
added a commit
to SethTisue/scala
that referenced
this pull request
May 9, 2022
as per discussion on scala#10017, we were flagging too many characters. a false positive came up in the community build; I modified the test case to include it.
|
adjusted a bit by #10030 |
SethTisue
changed the title
danarmak
added a commit
to danarmak/scala
that referenced
this pull request
Oct 21, 2022
…source files Update documentation with changes made in scala#10017, scala#10023, scala#10030
danarmak
added a commit
to danarmak/scala
that referenced
this pull request
Oct 27, 2022
…source files Update documentation with changes made in scala#10017
danarmak
added a commit
to danarmak/scala
that referenced
this pull request
Oct 27, 2022
…source files Update documentation with changes made in scala#10017
danarmak
added a commit
to danarmak/scala
that referenced
this pull request
Oct 27, 2022
…source files Update documentation with changes made in scala#10017
danarmak
added a commit
to danarmak/scala
that referenced
this pull request
Oct 31, 2022
…source files Update documentation with changes made in scala#10017
danarmak
added a commit
to danarmak/scala
that referenced
this pull request
Oct 31, 2022
…source files Update documentation with changes made in scala#10017
danarmak
added a commit
to danarmak/scala
that referenced
this pull request
Oct 31, 2022
…source files Update documentation with changes made in scala#10017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Don't allow characters with unicode property
Bidi_Classin source files. String / character literals can contain such characters through unicode escapes.Fixes scala/bug#12478