get-port override not needed since cypress@v11 #245
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Looks like since about cypress 11, node modules are being preloaded into a custom v8 snapshot which makes our override a noop.
FriggaHel
approved these changes
May 3, 2023
tianfeng92
approved these changes
May 3, 2023
alexplischke
approved these changes
May 3, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Looks like since about cypress 11, node modules are being preloaded into a custom v8 snapshot which makes our override a noop.
It's difficult to know for certain, but here are the clues:
Cypress/12.11.0/Cypress.app/Contents/Resources/app/node_modules/get-portno longer contains any code. No other references to get-port in the app bundle except in a binary:Cypress/12.11.0/Cypress.app/Contents/Frameworks/Electron Framework.framework/Versions/A/Resources/browser_v8_context_snapshot.binbrowser_v8_context_snapshot.binis an electron feature to load a custom v8 snapshot (https://www.electronjs.org/docs/latest/tutorial/fuses#loadbrowserprocessspecificv8snapshot)