get-port override not needed since cypress@v11 (#245)

Looks like since about cypress 11, node modules are being preloaded into a custom v8 snapshot which makes our override a noop.
saucelabs · May 4, 2023 · a49b030 · a49b030
1 parent f848b78
commit a49b030
Show file tree

Hide file tree

Showing 6 changed files with 0 additions and 426 deletions.
diff --git a/.github/workflows/test.yml b/.github/workflows/test.yml
@@ -110,11 +110,6 @@ jobs:
         run: |
           Write-Output "cypress_version=$((Get-Content ./package.json -Raw | ConvertFrom-Json).dependencies.cypress)" >> $env:GITHUB_ENV
 
-      - name: Override Dependencies
-        run: |
-          rm -r bundle/Cache/${{ env.cypress_version }}/Cypress/resources/app/node_modules/get-port
-          cp -r vendor/get-port bundle/cache/${{ env.cypress_version }}/Cypress/resources/app/node_modules
-
       - name: Archive Bundle
         uses: azure/powershell@v1
         with:
@@ -168,11 +163,6 @@ jobs:
           CYPRESS_VERSION=$(< package-lock.json jq -r '.dependencies["cypress"].version')
           echo "cypress_version=$CYPRESS_VERSION" >> $GITHUB_ENV
 
-      - name: Override Dependencies
-        run: |
-          rm -r bundle/Cache/${{ env.cypress_version }}/Cypress.app/Contents/Resources/app/node_modules/get-port
-          cp -r vendor/get-port bundle/Cache/${{ env.cypress_version }}/Cypress.app/Contents/Resources/app/node_modules/
-
       - name: Archive Bundle
         run: zip --symlinks -r cypress-macos-amd64.zip bundle/
 

diff --git a/vendor/get-port/index.d.ts b/vendor/get-port/index.d.ts
diff --git a/vendor/get-port/index.js b/vendor/get-port/index.js
diff --git a/vendor/get-port/license b/vendor/get-port/license
diff --git a/vendor/get-port/package.json b/vendor/get-port/package.json