Use Dart Sass and the embedded compiler from HEAD by default #175
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jathak
approved these changes
Dec 16, 2022
nex3
changed the title
nex3
force-pushed
the
update-dart-sass-dep
branch
from
b1d0f17
to
394d8e3
Compare
This matches the behavior of other CI tooling, and is low-risk since the release process releases the versions from HEAD anyway. It also eliminates the need to make empty version-only updates to the compiler just to make logic in Dart Sass visible to the test infrastructure. This also refactors the tool/ directory to move each individual `getX()` function into its own file, rather than lumping them all together in the ambiguously-named `utils.ts`. Any utils functions that are only used in one file have been moved to that file.
nex3
force-pushed
the
update-dart-sass-dep
branch
from
394d8e3
to
444833e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This matches the behavior of other CI tooling, and is low-risk since
the release process releases the versions from HEAD anyway. It also
eliminates the need to make empty version-only updates to the compiler
just to make logic in Dart Sass visible to the test infrastructure.
This also refactors the tool/ directory to move each individual
getX()function into its own file, rather than lumping them alltogether in the ambiguously-named
utils.ts. Any utils functions thatare only used in one file have been moved to that file.