Add tests for string.split() #1841
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nex3
requested changes
Nov 17, 2022
nex3
approved these changes
Nov 21, 2022
nex3
requested changes
Dec 9, 2022
There was a problem hiding this comment.
A couple missing tests I only noticed once I started in on the implementation:
- The function should return a comma separator even for empty and single-element lists.
- The function should accept unquoted strings, and should return an unquoted string if
$stringis unquoted.
There are a couple other small things, but I can auto-update them once I have write access to the PR.
This was referenced Dec 9, 2022
|
Added new tests for unquoted strings and checking the separator type for empty and single-element lists in 175359d. I think this covers the changes requested. |
nex3
approved these changes
Dec 13, 2022
|
Test failures should be fixed when sass/embedded-host-node#175 lands. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes: #1832
See: sass/sass#1950
[skip dart-sass]