Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reset the forwarded config to empty for @use and meta.load-module() #855

Merged
merged 2 commits into from Oct 22, 2019
Merged

Reset the forwarded config to empty for @use and meta.load-module() #855

merged 2 commits into from Oct 22, 2019

Commits on Oct 18, 2019

  1. Reset the forwarded config to empty for @use and meta.load-module() 

    In #827 I made configuration never be null, but this turns out to be
overkill: we still need a way for _loadModule() and _execute() to
distinguish between "use the existing configuration" (for @forward)
and "use no configuration" (for an unconfigured @use or
meta.load-module()). We now use null as a sentinel value there, while
still ensuring that _configuration is non-nullable.

Closes #854
    @nex3
    nex3 committed Oct 18, 2019
    Configuration menu
    Copy the full SHA
    01e03f1 View commit details
    Browse the repository at this point in the history

Commits on Oct 21, 2019

  1. Merge branch 'master' of github.com:sass/dart-sass into config-bug

    @nex3
    nex3 committed Oct 21, 2019
    Configuration menu
    Copy the full SHA
    6e30f78 View commit details
    Browse the repository at this point in the history